Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show how many people are online #53

Open
felixroos opened this issue Jan 6, 2025 · 6 comments
Open

show how many people are online #53

felixroos opened this issue Jan 6, 2025 · 6 comments
Labels
enhancement New feature or request flok

Comments

@felixroos
Copy link
Collaborator

somewhere, maybe it can also be in the mantra area. maybe also show the names of everyone

@DhruvSinha2003
Copy link
Collaborator

is there a sophisticated way to do this built in within flok?
or would adding event listeners (and cleaning them up with beforeunload) be appropriate?

@munshkr
Copy link

munshkr commented Jan 7, 2025

Flok is not tracking players names, but they are stored within the "local awareness" object of each peer in Yjs (as well as it's current caret position). Maybe there is a way to ask the Yjs provider these objects when connecting and building the players list?

@munshkr
Copy link

munshkr commented Jan 7, 2025

I guess we could also modify Flok's Websockets PubSub server to broadcast the connected players when they connect too.

@DhruvSinha2003
Copy link
Collaborator

ah okk
outside my paygrade then haha

@TristanCacqueray
Copy link
Collaborator

TristanCacqueray commented Jan 8, 2025

Would be nice to display the player count in each panels too, e.g. to see which one are active

@felixroos felixroos added the enhancement New feature or request label Jan 22, 2025
@felixroos
Copy link
Collaborator Author

I guess we could also modify Flok's Websockets PubSub server to broadcast the connected users when they connect too.

that would be pretty cool! it would probably increase the feeling of presence

@felixroos felixroos added the flok label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flok
Projects
None yet
Development

No branches or pull requests

4 participants