Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code needs a small update to work with Pd 0.52 #2

Open
shakfu opened this issue Jan 6, 2022 · 2 comments
Open

Code needs a small update to work with Pd 0.52 #2

shakfu opened this issue Jan 6, 2022 · 2 comments

Comments

@shakfu
Copy link

shakfu commented Jan 6, 2022

Pd 0.52 removed the error() function (unfortunately, without a deprecation notice), but it can easily be replaced with pd_error().

To fix the code in the repo you can run something like this in the project root:

rpl -R -x ".c" " error(" " pd_error(0, " .

patch.txt

A patch with the changes is attached.

@umlaeute
Copy link
Member

umlaeute commented Jan 9, 2022

pd_error() takes a handle to the object itself as a first argument, so the user can simply click on the error message to find the object that emitted the message.

so it's much preferred to provide an actual handle (e.g. pd_error(x, ...)) rather than just NULL.

@shakfu it might also be easier to just create a PR

@umlaeute
Copy link
Member

umlaeute commented Jan 9, 2022

oh, and actually you should direct the PR to https://github.com/ericlyon/pd-fftease which is where fftease is currently developed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants