Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if a node upgrade fixes the serde decoding errors. #579

Open
2 tasks
gianfra-t opened this issue Jan 23, 2025 · 1 comment
Open
2 tasks

Investigate if a node upgrade fixes the serde decoding errors. #579

gianfra-t opened this issue Jan 23, 2025 · 1 comment

Comments

@gianfra-t
Copy link
Contributor

gianfra-t commented Jan 23, 2025

Context

After the upgrade, we removed serde renaming to camelCase on some primitives from Spacewalk (see this discussion).

This was done to solve an issue in which the pendulum and spacewalk-standalone binaries were unable to start due to this re-definition, since after the upgrade, it is required to serialize the genesis config.

Although this removal did not impact anything initially, and integration tests worked correctly, the vault failed when connecting to the live nodes. Error seen from the vault's logs:

ERROR vault::system: start(): Failed to run service: Retry(RuntimeError(SubxtRuntimeError(Serialization(Error("unknown variant `xCM`, expected one of `Native`, `XCM`, `Stellar`, `ZenlinkLPToken`, `Token`", line: 1, column: 99)))))

Therefore, a rollback was implemented. This fixes the vault's connection issue, yet breaks the runtimes again (see this test, for example).

To Do's

We believe the binary of the nodes running is the issue, since they have not yet been upgraded. Only with the upgrade to 1.6.0 the renaming is removed, but the live nodes were compiled with a version of Spacewalk in which the primitive types do have the renaming macro enabled. This mismatch might be causing this issue.

In order to test (and potentially fix) this, we must:

  • Upgrade one of the nodes to 1.6.0. For example, one Foucoco collator.
  • Test the vault against this new updated node. The vault to test must be the one compiled at this commit hash, or any that includes the upgrade and the removal of serde renaming.
@gianfra-t
Copy link
Contributor Author

@pendulum-chain/product this is not urgent but must be done soon, since right now the solution implemented is not permanent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant