Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate robustness of redeem request step. #406

Closed
gianfra-t opened this issue Jan 23, 2025 · 4 comments
Closed

Investigate robustness of redeem request step. #406

gianfra-t opened this issue Jan 23, 2025 · 4 comments
Assignees
Labels
type:bug Something isn't working

Comments

@gianfra-t
Copy link
Contributor

Context

It was observed that the app was stuck at the redeem request step, with error {"type":"recoverable","message":"Error: Failed to request redeem"}}.

Nevertheless, the request was done properly and the transaction went through. It is unclear why the app returned this error and why it couldn't recover.

To Do

Analyze that part of the code (here and here for example) and check what can be improved such that if any generic submission error arises, we still can recover or be sure that the extrinsic did fail, and not just the response of submitting it.

@gianfra-t gianfra-t added the type:bug Something isn't working label Jan 23, 2025
@gianfra-t
Copy link
Contributor Author

@pendulum-chain/product this bug has been observed or at least documented only once. It is important as it happens at the redeem stage of the flow and funds are on the ephemeral account. Offramp can be recovered easily by executing the dumped transactions, but it is irrecoverable if those are lost.

@gianfra-t gianfra-t self-assigned this Jan 27, 2025
@prayagd
Copy link
Collaborator

prayagd commented Mar 5, 2025

@gianfra-t what's the status here? i dont see a linked PR to it as this is in review

@gianfra-t
Copy link
Contributor Author

Good catch, we kept the conversation internal. We couldn't find the issue since the app should reload in case of a failure like this, and not "get stuck". It also didn't happen again.

I think the conclusion was to do nothing regarding this, so we could close the issue. C.C. @pendulum-chain/devs

@ebma
Copy link
Member

ebma commented Mar 5, 2025

Yes, I think it's hard to debug so a wont-fix.

@ebma ebma closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants