Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

489 change formatstyling of quote comparison #494

Open
wants to merge 10 commits into
base: staging
Choose a base branch
from

Conversation

gianfra-t
Copy link
Contributor

@gianfra-t gianfra-t commented Mar 3, 2025

Note: Please, merge first #491 first.

Issue: #489.

This PR changes the formatting of the price provided by competitors, as well as a green highlight for the Vortex entry when the comparison is better.

@gianfra-t gianfra-t linked an issue Mar 3, 2025 that may be closed by this pull request
Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for pendulum-pay ready!

Name Link
🔨 Latest commit 987b8c5
🔍 Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/67c75cd2215f820008b4b6c3
😎 Deploy Preview https://deploy-preview-494--pendulum-pay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gianfra-t
Copy link
Contributor Author

@pendulum-chain/devs since we can't get the query using the preview, here are a couple screenshots, both a positive and negative comparison:
image
image

@gianfra-t gianfra-t requested a review from a team March 3, 2025 18:11
@ebma
Copy link
Member

ebma commented Mar 4, 2025

I didn't check the code yet but first want to clarify. If a provider other than Vortex has the best rate, we should be fair and also give them the "best rate"-rectangle. This doesn't seem to be the case on your second screenshot, or is it?

@gianfra-t
Copy link
Contributor Author

This doesn't seem to be the case on your second screenshot, or is it?

Exactly... I assumed we would aim to always be lower.

@ebma
Copy link
Member

ebma commented Mar 4, 2025

Haha yes of course. Ideally, it's only shown for Vortex 🤡 IIRC wise was also highlighting the other competitors if someone else had in fact the best rate.

@gianfra-t
Copy link
Contributor Author

@pendulum-chain/devs any provider will be highlighted now, if the rate is better.

@ebma
Copy link
Member

ebma commented Mar 5, 2025

One minor thing that I just realized which could be improved is that instead of using Vortex as the baseline it might make more sense to use the best rate as the baseline and then show the deduction on the others. Taking the example on the screenshot, instead of showing '0.60 EUR' on AlchemyPay, we could show '-0.60 EUR' on Vortex.

I'm just sharing some thoughts here, we don't need to do it here or ever.

image

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@gianfra-t
Copy link
Contributor Author

gianfra-t commented Mar 5, 2025

I think you're right. But that will require a bit more of a refactor probably. We clearly thought initially that the Vortex entry would be different, but if we do like that, where the baseline is the best price and all display the discounted amount, then we should treat Vortex as another provider.

@ebma
Copy link
Member

ebma commented Mar 5, 2025

Let's ignore that for now. I'm fine if we merge this PR as is and move the discussion elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change format/styling of quote comparison
3 participants