-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
489 change formatstyling of quote comparison #494
base: staging
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I didn't check the code yet but first want to clarify. If a provider other than Vortex has the best rate, we should be fair and also give them the "best rate"-rectangle. This doesn't seem to be the case on your second screenshot, or is it? |
Exactly... I assumed we would aim to always be lower. |
Haha yes of course. Ideally, it's only shown for Vortex 🤡 IIRC wise was also highlighting the other competitors if someone else had in fact the best rate. |
@pendulum-chain/devs any provider will be highlighted now, if the rate is better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
I think you're right. But that will require a bit more of a refactor probably. We clearly thought initially that the Vortex entry would be different, but if we do like that, where the baseline is the best price and all display the discounted amount, then we should treat Vortex as another provider. |
Let's ignore that for now. I'm fine if we merge this PR as is and move the discussion elsewhere. |
Note: Please, merge first #491 first.
Issue: #489.
This PR changes the formatting of the price provided by competitors, as well as a green highlight for the Vortex entry when the comparison is better.