Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect units for metrics #51

Open
myllynen opened this issue Mar 19, 2018 · 0 comments
Open

Incorrect units for metrics #51

myllynen opened this issue Mar 19, 2018 · 0 comments

Comments

@myllynen
Copy link
Contributor

At least string metrics have wrong units:

$ pminfo -dmtT mmv.test.java.runtime_name

mmv.test.java.runtime_name PMID: 70.3154.734 [An internal Java process identifier]
    Data Type: string  InDom: PM_INDOM_NULL 0xffffffff
    Semantics: discrete  Units: count
Help:
An internal Java process identifier
$ 

There was also discussion whether using unsigned integers/longs should be considered at for counters and other metrics which can only be positive; with Java 8 and Guava this should be possible but it's debatable whether this kind of change would be worth the effort (unlike with the above string example where units should certainly be corrected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant