Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: concurrently repairing indexes #59159

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

br: concurrently repairing indexes #59159

wants to merge 2 commits into from

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Jan 23, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #59158

Problem Summary:
Currently BR repairs ingest indexes (delete + add index) one by one, which can not take advantage of the DDL concurrent adding indexes feature.

What changed and how does it work?

Create more sessions to repair ingest indexes concurrently.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from leavrth, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jan 23, 2025
@tiprow tiprow
Copy link

tiprow bot commented Jan 23, 2025

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 48.42105% with 49 lines in your changes missing coverage. Please review.

Project coverage is 74.6058%. Comparing base (9c37399) to head (4feb43b).
Report is 22 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #59159        +/-   ##
================================================
+ Coverage   73.0489%   74.6058%   +1.5569%     
================================================
  Files          1684       1705        +21     
  Lines        466386     480170     +13784     
================================================
+ Hits         340690     358235     +17545     
+ Misses       104751      99475      -5276     
- Partials      20945      22460      +1515
Flag Coverage Δ
integration 46.0086% <48.4210%> (?)
unit 72.2649% <2.1052%> (+0.0231%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 60.0556% <48.4210%> (+14.7323%) ⬆️

@Leavrth
commit some suggestions
4feb43b 
Signed-off-by: Jianjun Liao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger left review comments

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

repair ingest indexes concurrently during log restore
2 participants
@Leavrth @BornChanger