Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: migrate the the feature about max_user_connections from PingkaiDB to community | tidb-test=pr/2474 #59197

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

executor: migrate the the feature about max_user_connections from PingkaiDB to community | tidb-test=pr/2474 #59197

wants to merge 6 commits into from

Conversation

joccau
Copy link
Member

@joccau joccau commented Jan 24, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #59203

Problem Summary:

What changed and how does it work?

  • TiDB supports max_user_connections to limits the login count when login tidb-server.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

integration test case

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

TiDB supports max_user_connections to limits the login count.

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 24, 2025
@joccau joccau force-pushed the cp-max-user-connections branch from c702551 to bad08f0 Compare January 24, 2025 10:04
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign d3hunter, yudongusa for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joccau joccau changed the title migrate the the feature about max_user_connections from PingkaiDB to community tidb. executor: migrate the the feature about max_user_connections from PingkaiDB to community. Jan 24, 2025
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/invalid-title do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Jan 24, 2025
@joccau joccau force-pushed the cp-max-user-connections branch from 7bd87b1 to ab3c101 Compare January 24, 2025 14:49
@joccau
make prepare_bazel
0c43eb2 
Signed-off-by: joccau <[email protected]>
@joccau joccau force-pushed the cp-max-user-connections branch from ab3c101 to 0c43eb2 Compare January 24, 2025 14:50
@joccau joccau changed the title executor: migrate the the feature about max_user_connections from PingkaiDB to community. executor: migrate the the feature about max_user_connections from PingkaiDB to community | tidb-test=pr/2474 Jan 24, 2025
@tiprow tiprow
Copy link

tiprow bot commented Jan 24, 2025

@joccau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow b9c3ffc link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 24, 2025

@joccau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev b9c3ffc link true /test check-dev
idc-jenkins-ci-tidb/build b9c3ffc link true /test build
idc-jenkins-ci-tidb/mysql-test b9c3ffc link true /test mysql-test
idc-jenkins-ci-tidb/unit-test b9c3ffc link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiDB supports max_user_connections to limits the login count when login tidb-server.
1 participant
@joccau