Add Deployment definition in SDK #5611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo
requested review from
khanhtc1202,
t-kikuc and
Warashi
as code owners
|
Checking the failed test case... |
Signed-off-by: Yoshiki Fujikane <[email protected]>
khanhtc1202
reviewed
Feb 28, 2025
| // CreatedAt is the time when the deployment was created. | ||
| CreatedAt int64 | ||
| } | ||
|
|
There was a problem hiding this comment.
should add comment to describe what this function does/use for (like we did in L582). The name newXXX is too confusing.
There was a problem hiding this comment.
@khanhtc1202
Thanks, added comment
9661323
Signed-off-by: Yoshiki Fujikane <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5611 +/- ##
==========================================
+ Coverage 26.56% 26.57% +0.01%
==========================================
Files 474 474
Lines 50535 50546 +11
==========================================
+ Hits 13423 13432 +9
- Misses 36048 36051 +3
+ Partials 1064 1063 -1 ☔ View full report in Codecov by Sentry. |
t-kikuc
approved these changes
Feb 28, 2025
khanhtc1202
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
We need some information for the Deployment itself.
I have recently added some fields for the k8s plugin and the wait approval plugin for now.
We can refine the fields later.
Which issue(s) this PR fixes:
Fixes #5530
Does this PR introduce a user-facing change?: