Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolRegistry as a common field for the Client in the SDK #5621

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Mar 4, 2025

What this PR does:

as title

Why we need it:

We need it to install tools to load manifests and deploy them to the platform for the platform-specific plugin.
(e.g. k8s plugin's DetermineStrategy, DetermineVersion, ExecuteStage)

Also, we need it for the stage plugin to execute any tool on the generic stage.

It is better to set it on the SDK side because it requires a piped service client.

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@ffjlabo ffjlabo marked this pull request as ready for review March 4, 2025 07:25
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 26.57%. Comparing base (6cf5097) to head (088f44e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/sdk/client.go 0.00% 2 Missing ⚠️
pkg/plugin/sdk/deployment.go 50.00% 1 Missing ⚠️
pkg/plugin/sdk/sdk.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5621      +/-   ##
==========================================
+ Coverage   26.56%   26.57%   +0.01%     
==========================================
  Files         475      475              
  Lines       50582    50590       +8     
==========================================
+ Hits        13438    13446       +8     
+ Misses      36081    36080       -1     
- Partials     1063     1064       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yoshiki Fujikane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant