Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect lack of internet #684

Open
dcvz opened this issue Aug 10, 2023 · 3 comments
Open

Detect lack of internet #684

dcvz opened this issue Aug 10, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@dcvz
Copy link

dcvz commented Aug 10, 2023

ATM if you try to do any internet bound command line tea -S and there's no internet connection tea will report its usual error screen:

panic: spilt tea. we’re sorry and we’ll fix it… but you have to report the bug!
    https://github.com/teaxyz/cli/issues/new?title=panic%3Aerror+sending+request+for+url+(https%3A%2F%2Fgithub.com%2Fteaxyz%2Fpantry%2Farchive%2Frefs%2Fheads%2Fmain.tar.gz)%3A+error+trying+to+connect%3A+dns+error%3A+failed+to+lookup+address+information%3A+nodename+nor+servname+provided%2C+or+not+known

TypeError: error sending request for url (https://github.com/teaxyz/pantry/archive/refs/heads/main.tar.gz): error trying to connect: dns error: failed to lookup address information: nodename nor servname provided, or not known
    at async mainFetch (ext:deno_fetch/26_fetch.js:266:12)
    at async fetch (ext:deno_fetch/26_fetch.js:490:7)
    ...

While any dev parsing this might easily realize what the issue is, it does invite the user to create an issue on Github. For a regular user it would save them and the tea team time by letting the user know the network is down and they should try again later.

@mxcl mxcl added the enhancement New feature or request label Oct 20, 2023
@michaelessiet
Copy link
Contributor

@jhheider would it be possible to catch lack of internet connection and display an appropriate error message?

@jhheider
Copy link
Contributor

lack of internet connection is a complicated idea. all the software really knows is if an HTTP request has failed. i'd check and see what our current error message is, but i need my internet connection for the moment. ;)

@michaelessiet
Copy link
Contributor

Screenshot 2023-12-28 at 21 18 38 This is the error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants