Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behavior for Japanese characters [segmentation fault] #30

Closed
minikomi opened this issue Aug 5, 2015 · 3 comments
Closed

Strange behavior for Japanese characters [segmentation fault] #30

minikomi opened this issue Aug 5, 2015 · 3 comments

Comments

@minikomi
Copy link

minikomi commented Aug 5, 2015

Steps to reproduce:

  1. Start planck REPL
  2. Insert or paste Japanese character - eg, あ - into REPL
  3. Press backspace once
  4. Press enter

Result:

λ ~ → planck -v
cljs.user=> �
[1]    66037 segmentation fault  planck -v
mfikes added a commit that referenced this issue Aug 5, 2015
It appears that linenoise doesn't support UTF8.
This change fixes the crash reported in #30.
@mfikes
Copy link
Member

mfikes commented Aug 5, 2015

With the crash fix it now looks like this:

$ ./planck
cljs.user=> ?
#<failed to decode input line>

cljs.user=> 

@minikomi
Copy link
Author

minikomi commented Aug 5, 2015

Great fast fix 😄
Thanks!

@mfikes
Copy link
Member

mfikes commented Aug 5, 2015

@minikomi FWIW, I tried https://github.com/msteveb/linenoise which is a fork supporting UTF-8, but I couldn't get it to work any differently for entering and properly cursoring over it.

Also, you can turn off the readline support in Planck via planck --plain-terminal and even then, in OS X terminal, the ability to delete あ characters doesn't seem to work properly.

@mfikes mfikes closed this as completed Aug 5, 2015
mfikes added a commit that referenced this issue Oct 17, 2015
It appears that linenoise doesn't support UTF8.
This change fixes the crash reported in #30.


Former-commit-id: d3a31c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants