Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Hidden' text contributes to score #28

Open
poblish opened this issue May 10, 2012 · 3 comments
Open

'Hidden' text contributes to score #28

poblish opened this issue May 10, 2012 · 3 comments
Labels
Minor

Comments

@poblish
Copy link
Owner

poblish commented May 10, 2012

See: http://planet.jboss.org/post/8_2_million_messages_second_with_specjms ... and click the 'Search' tab to see the hidden text.

It's confusing to show a high score when several banned terms are hidden - unfortunately I haven't found a way of determining that those terms are 'hidden'. All the usual checks (e.g. http://stackoverflow.com/a/1343350/954442) report that they are visible.

Annoying, but not a big deal.
@poblish
Copy link
Owner Author

poblish commented May 13, 2012

www.theaustralian.com.au is also a big pain in this regard.

poblish added a commit that referenced this issue May 13, 2012
@poblish
Fix Issue #28 by ignoring elements where 'display=none'
a58565f
@poblish
Copy link
Owner Author

poblish commented May 13, 2012

Fix might be a little over-zealous, but I'm pretty happy with it.

@poblish poblish closed this as completed May 13, 2012
@poblish poblish reopened this May 27, 2012
@poblish
Copy link
Owner Author

poblish commented May 27, 2012

Reopened for Firefox because a nasty FF/JQuery bug in the theJQNode.css('display') === 'none' check completely breaks that version. Have had to comment the check out for now, but it should be restored as and when safe.

See http://bit.ly/JZfHlp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@poblish