-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug Metrics #1474
Labels
Comments
@SyntaxNode - this is flagged with the PBS-Java label, but there's no Go PR linked and I don't see these strings in the Go codebase. Is this done in the Go implementation? |
Yes, this was completed for PBS-Go in #2246. |
Confirmed this is not yet ported to PBS-Java |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
This proposal addresses a discussion in #745 to provide hosts with visibility in how many auctions are running with debugging enabled.
Feature Request
Add new general metrics and new account metrics to track the number of requests received with debugging enabled through either the test or debug flag.
Add a new counter metric
requests_debug
which increments whenever a new request with debugging enabled is received. May be compared with the existingrequests
counter metric to determine percentages.Add a new account metric
account_requests_debug
which increments whenever a new request with debugging enabled for a specific account is received. May be compared with the existingaccount_requests
counter metric to determine percentages. Since account cardinality may be very high, this should be controlled with an option.Add a new
metrics.disabled.account_debug
config option to control enabling the account metric. Due to potentially very high account cardinality, this option will default totrue
, matching the default formetrics.disabled.account_adapter_details
.The text was updated successfully, but these errors were encountered: