-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject VAST impressions even if no impression tag #1967
Comments
@laurb9 Implemented this feature for PBS-Go. Do you have an opinion on this Laurentiu? |
I checked about this with Xandr's video team and got the following response:
From the above proposal, I believe we're good here.
About this, perhaps we need to include looking for the impression tag in the |
Hi all - I am part of Xandr's video team who provided the response that Mansi cited above. I wanted to add an additional comment to the above response. Above, it was mentioned that "SpotX creates VAST wrappers that rely on VPAID that do not create tags". This needn't be a factor that needs to be considered when adding an Impression node as a child to either the Inline node or to the Wrapper node. Per spec, any VPAID creative is required to report an AdImpression event to the player where the VPAID creative is being rendered. This allows the player to report any and all Impression value(s) that have been specified in VAST xml that is external to the VPAID creative. |
It's doing a full scan now. Anywhere it finds
I'm not familiar with VPAID, but would have to assume SpotX is doing the right thing here. Would we see an AdImpression event in the VAST? I do see this:
|
@bretg - |
Released with PBS-Java 1.71. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
The most recent Prebid Server Events and Analytics PRD defines the algorithm for injecting VAST impressions as:
Perhaps not surprisingly, a bidder has been found that doesn't conform to expectations. And it's none other my own company. :-). Though in my defense, it's a recent addition to the family... SpotX creates VAST wrappers that rely on VPAID that do not create tags.
So the updated proposal is:
Discussing with some internal VAST experts, we believe this should work, but would like to give the community a chance to weigh in.
The text was updated successfully, but these errors were encountered: