Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bid Adapters should be able to specify custom targeting #2031

Open
bretg opened this issue Oct 4, 2021 · 3 comments
Open

Bid Adapters should be able to specify custom targeting #2031

bretg opened this issue Oct 4, 2021 · 3 comments

Comments

@bretg
Copy link
Contributor

bretg commented Oct 4, 2021

Related tangentially to issue #2030

We discussed in committee that client-side adapters have the ability to supply custom targeting to the ad server. Server-side adapters should be able to do this as well.

We should define a syntax for where adapters can place the custom targeting. If it exists, PBS-core should copy it to the output seatbid.bid.ext.prebid.targeting (or for AMP, that special output format).

In order for publishers to be able to control this targeting, a new targeting control is proposed:

ext.prebid: {
  targeting: {
    ...
    includecustomkeys: ["bidderA"]     // default to "*". Set to empty string ("") to indicate none.
  }
}

Requirements:

  1. if a bidder places custom targeting in their response object, PBS-core must check the includecustomkeys parameter. If it doesn't exist, default to "*".
  2. If includecustomkeys is "", then ignore custom bidder targeting
  3. If includecustomkeys is "*", accept all custom bidder targeting by placing it on seatbid.bid.ext.prebid.targeting
  4. If includecustomkeys is an array of strings, check that the bidder's code is present on the array. If it is, then place it in seatbid.bid.ext.prebid.targeting
  5. This behavior should happen after the processing of includewinners, includebidderkeys, and includeformat.
  6. If a key that would be added is already in the destination, log a debug warning: "Not adding duplicate targeting key BLAH for bidder FOO."
  7. if a publisher supplies an invalid bidder, it is ignored.
  8. bidder name comparison should be case insensitive
@SyntaxNode
Copy link
Contributor

Hey @bretg, is this actually a duplicate of #289?

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@bretg
Copy link
Contributor Author

bretg commented Feb 3, 2022

Yup, duplicate. This one's better-defined so closed the other.

@SyntaxNode SyntaxNode added Ready For Dev Feature specification is ready to be developed. and removed enhancement labels Jun 28, 2022
@bretg bretg removed the projectboard label Sep 8, 2022
@bretg bretg moved this from Triage to Ready for Dev in Prebid Server Prioritization Oct 21, 2022
@bretg bretg removed the Ready For Dev Feature specification is ready to be developed. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Dev
Development

No branches or pull requests

2 participants