Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create images on dockerhub, github #2047

Open
bretg opened this issue Oct 15, 2021 · 4 comments
Open

Create images on dockerhub, github #2047

bretg opened this issue Oct 15, 2021 · 4 comments
Labels

Comments

@bretg
Copy link
Contributor

bretg commented Oct 15, 2021

The benefit of having the github workflows push images to a standard place is in helping everyone upgrade more often.

PBS-Go pushes images to dockerhub. Github is another place we could consider placing an image.

PBS-Java isn't publishing images at all right now, but it should do so to both dockerhub and github.

(Originally this considered creating official images for Prebid Server in dockerhub, but we've let go of that idea.)

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@bretg
Copy link
Contributor Author

bretg commented Oct 21, 2022

Xandr puts PBS-Go releases up on dockerhub. Other orgs do too. It would be nice if Prebid had an official release.

@muuki88
Copy link

muuki88 commented May 8, 2024

Images are published via this github action

publish-docker-image:
name: Publish docker image
needs: publish-tag
if: contains(inputs.debug, 'false')
runs-on: ubuntu-latest
steps:
- name: Checkout Prebid Server
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Build image
run: |
docker build -t docker.io/prebid/prebid-server:${{ needs.publish-tag.outputs.releaseTag }} .
- name: Login to docker Hub
if: contains(inputs.debug, 'false')
uses: docker/[email protected]
with:
username: ${{ secrets.DOCKERHUB_USER }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}
- name: Publish to docker Hub
run: |
docker push docker.io/prebid/prebid-server:${{ needs.publish-tag.outputs.releaseTag }}

They appear here: https://hub.docker.com/u/prebid

@bretg
Copy link
Contributor Author

bretg commented May 8, 2024

Discussed in committee:

  • The benefit of images is in helping everyone upgrade more often.
  • The value of an 'official' image is debatable. It already seems 'official enough'.
  • PBS-Java isn't publishing images at all right now. It should. To both dockerhub and github.
  • PBS-Go could start pushing images to the github repo. It could also change the image to support multiple architectures.

Will change this issue to drop the 'official' part, this can still track the image work.

@bretg bretg changed the title Create official images on dockerhub Create images on dockerhub, github May 8, 2024
@bretg bretg moved this from Needs Requirements to Ready for Dev in Prebid Server Prioritization May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Dev
Development

No branches or pull requests

2 participants