Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of impressions in auction request #4121

Open
linux019 opened this issue Dec 26, 2024 · 5 comments
Open

Limit number of impressions in auction request #4121

linux019 opened this issue Dec 26, 2024 · 5 comments

Comments

@linux019
Copy link
Contributor

linux019 commented Dec 26, 2024

Some bots or page crawlers send a request containing tens or hundred imps, eg 32...150. This is a useless traffic and it makes extra requests to bidder servers because some adapters send an impression as a separate HTTP request.
This is an example of their windows size, huge width

   "device": {
        "w": 1366,
        "h": 128810,
        "dnt": 0,
        "ua": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36",
        "language": "en",
    },

https://developers.google.com/publisher-tag/guides/publisher-console-messages#TOO_MANY_SLOTS_IN_SRA_REQUEST
It doesn't allow more than 30 ad slots.

Do you consider a PR that will add a impressions limit and a metric (counter with account_id label)?

@linux019 linux019 changed the title Proposal: limit number of impression in auction request Proposal: limit number of impressions in auction request Dec 26, 2024
@bretg
Copy link
Contributor

bretg commented Jan 10, 2025

Discussed in committee. We agreed that having an opt-in impression limit would be fine. Set this at the default account level that can be overridden by specific accounts.

auction.impression_limit: 50

  • 0 means no limit
  • Defaults to no limit
  • impression objects after this count are dropped
  • add a warning to the debug output

@linux019 - do you have a suggestion for what kind of metric you're looking for? We already have a top-level "imps_requested", perhaps a top-level "imps_dropped" metric?

@bretg bretg moved this from Triage to Clarify Request in Prebid Server Prioritization Jan 10, 2025
@linux019
Copy link
Contributor Author

linux019 commented Jan 12, 2025

I'm good with any name. The metric of type counter is ok to use rate() on it. ( https://prometheus.io/docs/prometheus/latest/querying/functions/#rate )

@bretg bretg moved this from Clarify Request to Community Review in Prebid Server Prioritization Jan 13, 2025
@bretg
Copy link
Contributor

bretg commented Jan 15, 2025

Discussed in committee. We agreed the metric can be called "imps_dropped" and that it should count the number of imps dropped.

Ready-for-Dev.

@bretg bretg moved this from Community Review to Ready for Dev in Prebid Server Prioritization Jan 15, 2025
@bretg bretg changed the title Proposal: limit number of impressions in auction request Limit number of impressions in auction request Jan 21, 2025
@bretg
Copy link
Contributor

bretg commented Jan 21, 2025

@linux019 - is this a feature you guys might be willing to contribute?

@linux019
Copy link
Contributor Author

Hi @bretg I'll submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Dev
Development

No branches or pull requests

2 participants