-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bidder-specific device data #4147
Comments
The same happens on pbs Java |
@paulborile - please provide an ORTB example. ext.prebid.bidderconfig.BIDDER.config.ortb2.device should get added to the ORTB seen by BIDDER as simply "device" |
Input request coming from prebid.js + wurfl rtd : some Bidder-Specific global FPD is set
(0test being our test Adapter) The following data is from MakeRequest of pubmatic adapter ( https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#makerequests )
While device.make and device.model had values in input request bidder-specific global fpd, here they are empty :
(In a similar way for the other device fields devicetype, os, osv, hwv, ppi, pxratio and js which are filled by prebid.js wurfl rtd) |
Actually, I do seem to recall that bidderconfig only supports merging ORTB for What's the use case for bidder-specific device data? This would be an enhancement request that's not going to be high priority. |
When a publisher uses prebid.js with WURFL RTD for device detection, bid requests routed through PBS lose the device enrichment provided by WURFL RTD. Bid requests sent directly to bidders retain this enrichment. |
The question is "why is it bidder-specific"? i.e. why can't the device enhancement be global to all bidders?
|
Our current business model involves sending different sets of information to specific bidders (similar to enabling device enrichment for specific publishers). To address the issue with bidder-specific data in Prebid Server, we are thinking at a new configuration option in the Prebid.js-WURFL RTD module: "Add device data to global ortb object (set true for Prebid Server)" [true/false]. When enabled, this option will ensure that device data is added to ortb2Fragments.global instead of ortb2Fragments.[bidder].data, specifically for use with Prebid Server. |
Very well, I've updated the title to reflect this is an enhancement request. I'm limiting it to just 'device' and not the entire ORTB object at this point. Will bring it up in a future PMC meeting where perhaps we'll decide to throw the doors wide open. |
Discussed in committee. Agreed to add |
We observed that when Prebid.js calls a Prebid Server (PBS), some bidder-specific global data (which appears in
.ext.prebid.bidderconfig[<bidder>].config.ortb2.device
when passed to PBS) is not forwarded to the bidders (it does not appear in the Bidder Request hook). Specifically, the device data added by, for example, the Prebid.js WURFL RTD module inortb2.device
is lost during transit in PBS.The text was updated successfully, but these errors were encountered: