-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n builds #271
Comments
pokeruby doesn't have the best system for language separation. An ideal setup would specify sources to use for each locale. Simple setup: ifeq ($(GAME_LANGUAGE),GERMAN)
LOC = de
else
LOC = en
endif
LOCALIZED_GFX := ...
$(LOCALIZED_GFX): %.2bpp: %.$(LOC).png |
Yeah, https://github.com/mid-kid/pokecrystal/tree/splitting has a workable system for that already with its version/ directory. |
https://github.com/mid-kid/pokecrystal/tree/i18n/version might be a better example, lol. |
@einstein95 also disassembled the Italian version; https://github.com/einstein95/pokered-it “Petros” disassembled the Spanish version; the repository is no longer on GitHub but I mirrored it at https://git.poke.blue/pokered-es/
Are you sure there was a Portuguese release? |
There wasn't a Portuguese release, at least none that are on no-intro (checked with a quick search on their database) |
I think that version I started but never finished |
The Japanese versions deserve their own project as they are different enough to warrant one:
The Chinese pirate versions, even though they aren't exactly official, may be deserving of their own project as well to see how the translators made sacrifices in the code to make those versions work:
|
Hello, I've been working on the Japanese versions of Red & Green, and the result is now online at pokegreen. I'll also start contributing to this repository with a number of suggestions/bugfixes I could find along the way. |
@iimarckus There wasn't any localization to Iberian/Hispanic Portuguese or Brazilian Portuguese, but I believe the Brazilian packaging by Gradiente was translated accordingly. @mauvesea might know more.
Thank you for your excellent work, @Narishma-gb! I see pokegreen is missing the 3DS VC changes so here are the patch files for Japanese Red v1.1 and Japanese Green v1.1. |
Thanks, I return the compliment! The work that was done here on pokered is absolutely amazing, documenting and labelling every piece of code and data. Also, there is one stray Hex address left in |
That's splendid and no worries, kindly take your time! 😄
Thank you for spotting that, we'll look into it 😃 |
The French and German versions are already disassembled:
There were also Spanish, Italian, and Portuguese releases.
With a system like pokeruby has to keep different languages' data separate, so code files don't get cluttered with
IF
/ELSE
s, these could all be in one repo.See also: pret/pokecrystal#626 and https://github.com/mid-kid/pokecrystal/tree/splitting
The text was updated successfully, but these errors were encountered: