Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Improve anchor link support on mobile in SubdomainNavBar #658

Open
simurai opened this issue Jul 22, 2024 · 3 comments
Open
Assignees
Labels

Comments

@simurai
Copy link
Contributor

simurai commented Jul 22, 2024

Problem

Currently you can use an "anchor/deep" link (e.g. /#agenda) with SubdomainNavBar. But since the "hamburger menu" takes up almost the full width/height (we customized it a bit to add a gap), you can't really see that clicking the link changed anything and you have to click on the close "X" button to close the menu.

Steps to reproduce:

  1. Resize browser to mobile
  2. Go to this preview. (Internal)
  3. Click on the "hamburger" menu button
  4. Click on "Agenda" or "Pricing"
  5. Notice that the menu still stays open.
Screen.Recording.2024-07-22.at.10.49.51.mov

Possible solution

When clicking an "anchor/deep" link, the menu on mobile should close.

Urgency

This came up in this project (internal link). We found a workaround by programmatically trigger a close() on the close "X" button.

Screen.Recording.2024-07-22.at.10.32.44.mov

So not too urgent, but might still be nice to support "anchor/deep" links with SubdomainNavBar so we don't have to rely on the [aria-controls="menu-navigation"] selector. 🙈

@rezrah rezrah added the brand label Jul 22, 2024
@rezrah
Copy link
Collaborator

rezrah commented Jul 22, 2024

Update from planning: Waiting on Site Design to confirm this is the correct solution before triaging further.

@rezrah
Copy link
Collaborator

rezrah commented Aug 6, 2024

cc. @nsolerieu (Site FR)

@nsolerieu
Copy link
Contributor

@rezrah just check in with @jesussandreas - we approve @simurai thoughtful fix suggestion

@rezrah rezrah self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants