Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modification request] All links to be blue #770

Open
nsolerieu opened this issue Sep 25, 2024 · 6 comments
Open

[Modification request] All links to be blue #770

nsolerieu opened this issue Sep 25, 2024 · 6 comments
Assignees

Comments

@nsolerieu
Copy link
Contributor

nsolerieu commented Sep 25, 2024

Context

During the refactoring of our feature pages we've been using lots of rivers, pillars, cards, bento with links. The inconsistent color has been noticed at many occasion by different stakeholders.

  • River links are black/white
    Image

  • Cards links are blue
    Image

Design suggestion

Align all components that offer link to use the blue to default to blue links

@simurai
Copy link
Contributor

simurai commented Sep 26, 2024

Issue (internal link) for the feature pages.

@samoshin
Copy link

Thanks for kicking this off 🙏

@joshfarrant
Copy link
Contributor

Thanks @nsolerieu — consistency makes sense to me!

I'd be keen to get @danielguillan's thoughts on this as I don't have historical context on whether the differing colours are an oversight, or an intentional choice

@tallys
Copy link

tallys commented Oct 4, 2024

Yeah I'm in for consistency — @danielguillan let me know if you have more context here

@danielguillan
Copy link
Contributor

The different colors were intentional but purely aesthetic choices based on the page designs these components supported when they were introduced. I also recommend updating these to use blue by default.

There is at least one additional component that doesn't use blue links, and we should consider it as well: SectionIntro.

@samoshin
Copy link

There is at least one additional component that doesn't use blue links, and we should consider it as well: SectionIntro.

I'm supportive of making links blue globally and by default.

@danielguillan danielguillan self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

6 participants