Increased spacing between River components on mobile viewports
#791
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 461d00b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔍 Design token changes foundView CSS variable changes- --brand-River-spacing-outer: var(--base-size-28);
+ --brand-River-spacing-outer: var(--base-size-36); |
joshfarrant
force-pushed
the
joshfarrant/river-mobile-spacing
branch
from
bcde572
to
461d00b
Compare
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
rezrah
reviewed
Oct 22, 2024
| @@ -13,7 +13,7 @@ | |||
| } | |||
| }, | |||
| "outer": { | |||
| "value": "var(--base-size-28)", | |||
| "value": "var(--base-size-36)", | |||
| "responsive": { | |||
| "768px": { | |||
| "value": "var(--base-size-36)" | |||
There was a problem hiding this comment.
You can remove the 768px breakpoint now given it's the same
rezrah
reviewed
Oct 22, 2024
| '@primer/react-brand': patch | ||
| --- | ||
|
|
||
| Increased spacing between `River` components on mobile viewports. |
There was a problem hiding this comment.
Suggested change
| Increased spacing between `River` components on mobile viewports. | |
| Increased spacing between `River` components on narrow viewports from `28px` to `36px` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of notable changes:
Riverouter padding fromvar(--base-size-28)tovar(--base-size-36)on mobile viewportsWhat should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist:
Screenshots: