Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - Bento.Item removes vertical padding #792

Open
stefankp opened this issue Oct 17, 2024 · 0 comments
Open

🐛 [BUG] - Bento.Item removes vertical padding #792

stefankp opened this issue Oct 17, 2024 · 0 comments
Labels
brand bug Something isn't working

Comments

@stefankp
Copy link

Describe the bug

A simple Bento.Item without background, has vertical padding removed by row-padding-override. This doesn't happen when the visualAsBackground is set, even if there's no visual. Which is also the case for the No Visual example in Storybook.

Reproduction steps

Reproduce here https://primer.style/brand/components/Bento with the following snippet:

<Box
  style={{backgroundColor: 'var(--base-color-scale-gray-2)'}}
  padding="normal"
>
  <Bento>
    <Bento.Item>
      <Bento.Content>
        <Bento.Heading>
          Heading
        </Bento.Heading>

        <Link href="#">
          Link
        </Link>
      </Bento.Content>
    </Bento.Item>
  </Bento>
</Box>

Expected behavior

Padding should stay consistent or it should be clear why vertical padding is removed.

Screenshots

Bento item with no vertical padding

row-padding-override styles applied

Browsers

No response

OS

No response

@stefankp stefankp added the bug Something isn't working label Oct 17, 2024
@rezrah rezrah added the brand label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants