Ignore the blended messages #722
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
blending-ignore
branch
4 times, most recently
from
e232918 to
4b1f364
Compare
Comment on lines
-84
to
-90
| _PYLINT_EQUIVALENTS = { | ||
| # TODO: blending has this info already? | ||
| "unused-import": ( | ||
| ("pyflakes", "FL0001"), | ||
| ("frosted", "E101"), | ||
| ) | ||
| } |
prospector/tools/ruff/__init__.py
Outdated
Comment on lines
15
to
16
| _IGNORE_RE = re.compile(r"#\s*noqa:([^#]*[^# ])(?:\s*#.*)?$", re.IGNORECASE) | ||
|
|
There was a problem hiding this comment.
Might want to add this to the ToolBase class for clarity ?
There was a problem hiding this comment.
The change is nice but I meant add the regex as an attribute in the ToolBase class to specify the regex for a tool noqa/disable explicitly (make it part of the ToolBase's API instead of creating a constant for each tool).
There was a problem hiding this comment.
Like the new commit?
I'm nor relay convinced, but it does the job :-)
(I should update the tests!)
There was a problem hiding this comment.
Yeap ! My reasoning is that the regex is strongly linked to a particular tool, but I don't mind if you revert, it's a nit.
sbrunner
force-pushed
the
blending-ignore
branch
from
4b1f364 to
8930755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When one of the blended messages is ignored, ignore the other.
Related Issue
Fix #720
Motivation and Context
How Has This Been Tested?
New tests added
Types of changes