Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for per repository version uniqueness constraints #394

Open
pulpbot opened this issue Jan 4, 2022 · 2 comments
Open

Comments

@pulpbot
Copy link
Member

pulpbot commented Jan 4, 2022

Author: @quba42 (quba42)

Redmine Issue: 7441, https://pulp.plan.io/issues/7441


Provide test coverage for: https://pulp.plan.io/issues/6429

I deferred the test coverage in the interest of getting this issue merged, but I still think test coverage would be useful (and at this point I have a fairly detailed idea of what would be needed):

Minimal test:

Create a repository
Upload https://fixtures.pulpproject.org/debian/pool/asgard/o/odin/odin_1.0_ppc64.deb to it.
Also upload https://fixtures.pulpproject.org/debian-complex-dists/pool/asgard/o/odin/odin_1.0_ppc64.deb to it.
Assert that the second repository version has only one package in it, and that the first package was removed from the version.

If we want to be fancy:

Add both packages to an empty repository in a single API call.
Assert that the relevant error is thrown.

Add both packages to the repository from the minimal test using a single API call.
Assert that the new version still only has one package in it.

Extra fancy:

Build a third colliding package in the fixtures.
Add all three to the repository from the minimal test in a single API call.
Assert that the relevant error is thrown.

@pulpbot pulpbot added this to the Testing milestone Jan 4, 2022
@quba42 quba42 removed New labels Jan 31, 2022
@stale
Copy link

stale bot commented May 25, 2022

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label May 25, 2022
@quba42 quba42 added the Tests label Jun 20, 2023
@stale
Copy link

stale bot commented Jun 20, 2023

This issue is no longer marked for closure.

@stale stale bot removed the stale label Jun 20, 2023
@quba42 quba42 removed this from the Testing milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants