Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail substitution macros not following configuration, reverting to default values #641

Open
SalutAToi opened this issue Feb 16, 2022 · 0 comments

Comments

@SalutAToi
Copy link

SalutAToi commented Feb 16, 2022

Hi !

I'm using the latest version built from source (2.1.0) and I'm having issue with the from email macro substitution for both the @SystemEmailFromAddress@ and the @DefaultEmailFromAddress@.

Even though I've defined some values in the configuration (I've also tried with the default values), the macro substitution does not happen. In the case of the @DefaultEmailFromAddress@, it simply fails to send something when trying with the test email function in the conf editor, because there's no fallback values (that I could find). Logs : 2022-02-16T20:25:55Z, ERROR, macro.MacroMachine, error while replacing macro '@DefaultEmailFromAddress@', error: null
In the case of the system notification (startup, modification), it tries to send an email with the fallback from value definied here : https://github.com/pwm-project/pwm/blob/7c849c94b7f91168c9a6afc250e14c9c6b57717b/server/src/main/java/password/pwm/util/macro/SystemMacros.java as can be seen from the logs :
fields: [from: Audit Event Notification <[email protected]>, to: [email protected], subject: PWM - Audit Event - Application Startup, com.sun.mail.smtp.SMTPSendFailedException: 550-5.7.0 Mail relay denied [ip]

However, in both cases, I had defined a value in the configuration for both addresses, and have tried with leaving the default value. I can see in the logs that PWM did in fact register the configuration change for those addresses :

2022-02-16T20:34:57Z, INFO , event.AuditService, {BF1uK,default,xx} audit event: {"type":"USER","eventCode":"MODIFY_CONFIGURATION","guid":"9cfde8be-6924-41ba-ad23-9118df653b20","timestamp":"2022-02-16T09:34:57Z","message":"configuration record '[Domain: system] ⇨ Setting ⇨ Settings ⇨ Email ⇨ Email Settings ⇨ Default System From Address' has been modified, new value: [email protected]","narrative":"Configuration has been modified, changes: configuration record '[Domain: system] ⇨ Setting ⇨ Settings ⇨ Email ⇨ Email Settings ⇨ Default System From Address' has been modified, new value: [email protected]","perpetratorID":"xx,"perpetratorLdapProfile":"default","sourceAddress":"10.6.200.5","sourceHost":"xx,"domain":"system"} [10.6.200.5]
2022-02-16T20:34:57Z, INFO , event.AuditService, {BF1uK,default,xx audit event: {"type":"USER","eventCode":"MODIFY_CONFIGURATION","guid":"3a6362b5-8218-4ce4-9d71-0c90962f079f","timestamp":"2022-02-16T09:34:57Z","message":"configuration record '[Domain: default] ⇨ Setting ⇨ Settings ⇨ Email ⇨ Email Templates ⇨ Default From Address' has been modified, new value: no-reply@xx","narrative":"Configuration has been modified, changes: configuration record '[Domain: default] ⇨ Setting ⇨ Settings ⇨ Email ⇨ Email Templates ⇨ Default From Address' has been modified, new value: no-reply@xx","perpetratorID":"xx","perpetratorDN":"xx,"perpetratorLdapProfile":"default","sourceAddress":"10.6.200.5","sourceHost":"xx","domain":"system"} [10.6.200.5]
2022-02-16T20:34:57Z, INFO , stored.ConfigurationReader, {BF1uK,default,xx beginning write to configuration file /srv/pwm/PwmConfiguration.xml.new [10.6.200.5]
2022-02-16T20:34:57Z, INFO , stored.ConfigurationReader, saved configuration (45ms)
2022-02-16T20:34:57Z, INFO , http.ContextManager, {#,context} beginning application restart (10ms), restart count=2
2022-02-16T20:34:57Z, WARN , pwm.PwmApplication, preparing for restart
2022-02-16T20:34:57Z, INFO , pwm.PwmApplication, PWM v2.1.0-SNAPSHOT b3869406 closed for bidness, cya! (4ms)
2022-02-16T20:34:57Z, INFO , pwm.PwmApplication, initializing, application mode=RUNNING, applicationPath=/srv/pwm, configFile=/srv/pwm/PwmConfiguration.xml
2022-02-16T20:34:57Z, WARN , localdb.LocalDBStoredQueue, trimmed 16 from head position against database EVENTLOG_EVENTS
2022-02-16T20:34:57Z, WARN , localdb.LocalDBStoredQueue, trimmed 3 from head position against database AUDIT_EVENTS
2022-02-16T20:35:00Z, INFO , pwm.PwmApplication, PWM v2.1.0-SNAPSHOT b3869406 open for bidness! (2711ms)
2022-02-16T20:35:00Z, INFO , http.ContextManager, {#,context} application restart completed (2783ms)

Version information :

bug-report-pwm
bug-report-pwm2

Thanks for your work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant