-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please tell us the meaning of the sentence #386
Comments
I think it may have gotten blurred together with the example after it? I think for the idea of testing special cases, one familiar example might be dividing by zero. Something like
except i don't have my writing voice on right now and it could use a bit of @lwasser 's writing voice in it :) |
Gosh - this specific line came from a review - possibly david or someone else. But i think Jonny has it right :) We want to encourage people to think about edge cases where something might fail. so division by 0. I don't now if there is some calculation where as a number gets really small it could fail, ect. I think the take away is "make sure that your tests consider edge cases". and we could add another take away that would say if you find a bug around an edge case, add a test that covers it! i hope that helps @tkoyama010 !! i am not sure if you are still working on this or not. i'm just going through OLD notifications and also cleaning up issues and pr's that maybe can be closed! |
@all-contributors please add @sneakers-the-rat and @lwasser for question |
I've put up a pull request to add @sneakers-the-rat! 🎉 |
@all-contributors please add @lwasser for question |
I've put up a pull request to add @lwasser! 🎉 |
The
with the input of both 0 and
part is missing information and cannot be read. Please tell us what you are trying to convey.python-package-guide/tests/write-tests.md
Line 84 in 53e10d6
The text was updated successfully, but these errors were encountered: