Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestions from pmd general assembly #1193

Open
ligerzero-ai opened this issue Sep 21, 2023 · 5 comments
Open

suggestions from pmd general assembly #1193

ligerzero-ai opened this issue Sep 21, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@ligerzero-ai
Copy link
Contributor

Suggestions from materialdigital general assembly.

Export an environment yaml inside the hdf5 file automatically?
Down to the granular (atomic dependencies... e.g. not just "pyiron_atomistics" but all the package versions that were used in a particular pyiron run?

@ligerzero-ai ligerzero-ai added the enhancement New feature or request label Sep 21, 2023
@jan-janssen
Copy link
Member

I like the idea, in particular when we move towards one HDF5 file per workflow rather than once HDF5 file per calculation.

@jan-janssen jan-janssen transferred this issue from pyiron/pyiron Sep 21, 2023
@ligerzero-ai
Copy link
Contributor Author

there was also a request to allow custom submission scripts - since there was a user that wanted to adjust parameters inside the job submission script across varying types of jobs.

@jan-janssen
Copy link
Member

there was also a request to allow custom submission scripts - since there was a user that wanted to adjust parameters inside the job submission script across varying types of jobs.

In pyiron_base this functionality is a bit hidden, but you can specify additional arguments using:

job.server.additional_arguments = {"my_parameter_1": 1, "my_parameter_2": 2} 

https://github.com/pyiron/pyiron_base/blob/main/pyiron_base/jobs/job/extension/server/generic.py#L120

We might have to document it a bit better. The full discussion on this topic is available in the corresponding pull request #1082

For future reference, the documentation is a bit better for pysqa as we set the custom parameters using the **kwargs. You can set any key and as long as it appears in your submission script template it is parsed correctly. https://pysqa.readthedocs.io/en/latest/python.html#submit-job-to-queue

@ligerzero-ai
Copy link
Contributor Author

so basically, replace the parameters that are changing anywhere in the jinja jobscript with the text
{{varying_parameter}}, {{varying_parameter2}} and specify it as

job.server.additional_arguments = {"varying_parameter": 1, "varying_parameter2": 2}}

right?

@jan-janssen
Copy link
Member

right?

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants