Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code duplication: For and Macro #374

Open
liamhuber opened this issue Jun 25, 2024 · 0 comments
Open

Code duplication: For and Macro #374

liamhuber opened this issue Jun 25, 2024 · 0 comments
Assignees

Comments

@liamhuber
Copy link
Member

In #373, the missing behaviour for for-loops to reload the value-links between their input and their children is added. Right now it's by straight-up code duplication from the Macro implementation. Instead this should come from a shared ancestor, e.g. StaticComposite in analogy to StaticNode. Right now that results in a circular import because Composite holds an instance of Creator; in the long run, Workflow should be better extracted from the node hierarchy, it should be the only one to hold the Creator, and I'll be able to introduce such a shared ancestor for these too.

@liamhuber liamhuber self-assigned this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant