Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyqtSignal needs the same treatment as pyqtSlot #105

Open
BryceBeagle opened this issue Oct 7, 2020 · 1 comment · May be fixed by #107
Open

pyqtSignal needs the same treatment as pyqtSlot #105

BryceBeagle opened this issue Oct 7, 2020 · 1 comment · May be fixed by #107
Assignees
@BryceBeagle

Comments

@BryceBeagle
Copy link
Collaborator

BryceBeagle commented Oct 7, 2020 •
edited
Loading

pyqtSignal.__init__ has bunch of parameters and overloads that are not properly annotated

https://www.riverbankcomputing.com/static/Docs/PyQt5/signals_slots.html#PyQt5.QtCore.pyqtSignal

https://github.com/stlehmann/PyQt5-stubs/blob/811462b34ee151b898289ae8f1de8af30c690c55/PyQt5-stubs/QtCore.pyi#L44-L45
@BryceBeagle
Copy link
Collaborator Author

This is related to #68 , but not necessarily about making the entire class generic

@BryceBeagle BryceBeagle self-assigned this Oct 7, 2020
@BryceBeagle BryceBeagle linked a pull request Oct 9, 2020 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BryceBeagle BryceBeagle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(WIP) Update the parameter type annotations for pyqtSignal.__init__ BryceBeagle/PyQt5-stubs
1 participant
@BryceBeagle