Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QScrollArea(widgetResizable) #148

Merged
merged 10 commits into from
Mar 14, 2022
Merged

QScrollArea(widgetResizable) #148

merged 10 commits into from
Mar 14, 2022

Conversation

altendky
Copy link
Collaborator

@altendky altendky commented Mar 27, 2021

Closes #147

@altendky
Copy link
Collaborator Author

Cool, this is apparently the first test to instantiate a widget... so time to fix up CI for GUI testing.

@altendky altendky marked this pull request as ready for review March 28, 2021 01:24
@altendky altendky requested a review from BryceBeagle March 28, 2021 01:24
@BryceBeagle
Copy link
Collaborator

If you want to begin going through with the herculean effort of adding the properties to the constructor signature, I guess we might as well add alignment too?

@altendky
Copy link
Collaborator Author

Why stop at non-inherited ones? :[ Mostly my brain went to 'someone else try to figure out how to work through all this with Phil' and 'PyQt6'.

@BryceBeagle
Copy link
Collaborator

BryceBeagle commented Mar 28, 2021

Why stop at non-inherited ones?

I figured we'd just get one class out of the way, but we may want to just make this a batch change. I wonder if it's possible to write a script to determine all the Qt Properties and modify all of the stubs at once.

Edit: oh but I see what you're saying. We can't rely on inheritance for the constructor signature 😭

@bluebird75 bluebird75 merged commit c002ab0 into master Mar 14, 2022
@bluebird75 bluebird75 deleted the altendky-patch-3 branch March 14, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set properties using keyword arguments in constructor
3 participants