Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression on latest pytorch nightly when using float8_dynamic_activation_float8_weight with granularity == PerTensor #1609

Open
vgoklani opened this issue Jan 23, 2025 · 2 comments

Comments

@vgoklani
Copy link

Nothing fancy here, just running single-batch inference on LLama3-1 8B with float8_dynamic_activation_float8_weight quantization with the granularity set to PerTensor().

{'ttft': 0.01968639945983887, 'input_token_throughput': 2946.1964397462616, 'output_token_throughput': 73.3861714881309, 'bandwidth': '628.29 GB/s', 'peak_memory_usage': '22.80 GB', 'model_size': '8.58 GB', 'torch_version': '2.6.0a0+df5bbc09d1.nv24.12', 'torchao_version': '0.7.0'}

{'ttft': 0.050607105255126954, 'input_token_throughput': 1146.0841260847276, 'output_token_throughput': 58.74973548302016, 'bandwidth': '502.05 GB/s', 'peak_memory_usage': '22.68 GB', 'model_size': '8.58 GB', 'torch_version': '2.7.0.dev20250122+cu126', 'torchao_version': '0.7.0'}

The second run was from the latest pytorch nightly and uses the same exact code (no changes). This was run on SM89 hardware (NVIDIA 6000 ADA LOVELACE).

Happy to help test if you have questions, thanks!

@supriyar
Copy link
Contributor

cc @drisspg any ideas on why this is the case?

@HDCharles @jainapurva hopefully our upcoming benchmarking work can catch regressions like these.

@drisspg
Copy link
Contributor

drisspg commented Jan 23, 2025

That Is pretty massive, is the the llama_eval script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants