Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One torrent is displayed in two error categories #22218

Open
stalkerok opened this issue Jan 29, 2025 · 24 comments
Open

One torrent is displayed in two error categories #22218

stalkerok opened this issue Jan 29, 2025 · 24 comments

Comments

@stalkerok
Copy link
Contributor

stalkerok commented Jan 29, 2025

qBittorrent & operating system versions

qBittorrent v5.0.3 (64-bit)
Qt: 6.7.3
Libtorrent: 1.2.19.0
Boost: 1.86.0
OpenSSL: 3.4.0
zlib: 1.3.1

What is the problem?

There is another problem with displaying the same torrent in two error categories.
You can use an old release of ubuntu (official) to test it.

magnet:?xt=urn:btih:2aa4f5a7e209e54b32803d43670971c4c8caaa05&dn=ubuntu-24.04-desktop-amd64.iso&tr=https%3A%2F%2Fubuntu.com%2Fannounce&tr=https%3A%2F%2Ftorrent.ubuntu.com%2Fannounce

Image

Also, if you stop the torrent, the errors don't go away. This is a long-standing problem, but I thought I'd mention it again.
Image

Steps to reproduce

No response

Additional context

No response

Log(s) & preferences file(s)

n/a

@stalkerok
Copy link
Contributor Author

@glassez FYI

@glassez
Copy link
Member

glassez commented Jan 29, 2025

There is another problem with displaying the same torrent in two error categories.
You can use an old release of ubuntu (official) to test it.

It has two trackers with different errors.

@stalkerok
Copy link
Contributor Author

It has two trackers with different errors.

Isn't there a priority? A tracker error should be prioritized over other errors. Anyway, it's weird to see one torrent in multiple categories.

@glassez
Copy link
Member

glassez commented Jan 29, 2025

@stalkerok
You are misunderstanding the essence of the filter.
I recently explained this in another thread. I don't remember where, so I'll repeat it.
This is (like all others) a torrent filter. It filters the list of torrents by some attribute. Some torrent matches the "tracker" filter if it contains a suitable tracker. The same is true for extra items ("warning", "tracker error" etc.).

@xavier2k6
Copy link
Member

I recently explained this in another thread. I don't remember where, so I'll repeat it.

@glassez #21201 (comment) ?

@glassez
Copy link
Member

glassez commented Jan 29, 2025

I recently explained this in another thread. I don't remember where, so I'll repeat it.

@glassez #21201 (comment) ?

No, that's not it. But it doesn't matter anymore, since I've outlined its essence above.

@stalkerok
Copy link
Contributor Author

I understand, but it doesn't seem like expected behavior to me. IMO there should be a priority in the classification of errors, otherwise in some cases the separation into other error and tracker error doesn't make sense. Torrents with many trackers for example, or when using automatic tracker addition, the torrent will always be in both other error and tracker error.

Also, it would be nice to split the tracker filter widget into tracker status and trackers. This will allow to quickly find a certain tracker with tracker error status, for example, if there are a lot of torrents with different errors.

@glassez
Copy link
Member

glassez commented Jan 29, 2025

It looks like you still want to have yet another torrent status aggregating the status of all its trackers according to some rule.
I don't have a clear idea about this. But if someone could explain to me with an example how this rule might look in your opinion... i.e. there is a torrent with N trackers (with different statuses), and we need to generate the "trackers related" torrent status based on them.

@stalkerok
Copy link
Contributor Author

No, the tracker error is the priority for me, I don't care if I have torrents with other errors. I just expect that there are different torrents in those categories.

@glassez
Copy link
Member

glassez commented Jan 30, 2025

Also, if you stop the torrent, the errors don't go away. This is a long-standing problem, but I thought I'd mention it again.

#22219 should take care of this problem.

@stalkerok
Copy link
Contributor Author

Good. Since this is expected behavior, it might be worth changing this issue to a feature request.
As I said, it would be nice to have error prioritization so that the same torrent is not duplicated everywhere:

  1. Tracker error.
  2. Other error.
  3. Warning.

@thalieht
Copy link
Contributor

I just expect that there are different torrents in those categories.

As I said, it would be nice to have error prioritization so that the same torrent is not duplicated everywhere:

I don't get it. Where's the harm in having the torrent in both?

@glassez
Copy link
Member

glassez commented Jan 30, 2025

Good. Since this is expected behavior, it might be worth changing this issue to a feature request. As I said, it would be nice to have error prioritization so that the same torrent is not duplicated everywhere:

  1. Tracker error.
  2. Other error.
  3. Warning.

They behave consistently with regular items (torrent is matched by each item it belongs to), so I'm against changing it. Besides, such a change will lead to the fact that it will not be possible to filter torrents by each of these criteria, but only by one of them (i.e. one couldn't find all torrents with tracker warnings or network related errors).

@stalkerok
Copy link
Contributor Author

I don't get it. Where's the harm in having the torrent in both?

IMO it just makes filtering more difficult. But I won't insist on it.

Also, it would be nice to split the tracker filter widget into tracker status and trackers. This will allow to quickly find a certain tracker with tracker error status, for example, if there are a lot of torrents with different errors.

What do you think about that?

@glassez
Copy link
Member

glassez commented Jan 30, 2025

Also, it would be nice to split the tracker filter widget into tracker status and trackers. This will allow to quickly find a certain tracker with tracker error status, for example, if there are a lot of torrents with different errors.

It's still unclear what exactly you mean.

@stalkerok
Copy link
Contributor Author

stalkerok commented Jan 30, 2025

It's still unclear what exactly you mean.

TRACKER STATUS
All
Trackerless
Tracker error
Other error
Warning

TRACKERS
All
torrent.ubuntu.com
ubuntu.com
etc

@glassez
Copy link
Member

glassez commented Jan 30, 2025

TRACKERS
All
torrent.ubuntu.com
ubuntu.com
etc

Trackerless is essential part of regular tracker filter so removing it from there (moving to another place) will break its functionality.

TRACKER STATUS
All
Trackerless
Tracker error
Other error
Warning

It makes no sense to separate this into a separate filter if it continues to work the same way as before. But if you change its behavior, then (as I mentioned above) we will lose some of the current usability.
So I wouldn't touch the existing Tracker filter.

@stalkerok
Copy link
Contributor Author

When there are a lot of torrents with errors, it is impossible to find out if there are errors on a certain tracker without the help of third party tools. Here is a good example: other error 5206, 5205 torrents have a tracker temporarily down, to find out which tracker is down on 5206 I need to go through all of them manually.
Image

@stalkerok
Copy link
Contributor Author

TRACKER STATUS
All
Tracker error
Other error
Warning

TRACKERS
All
Trackerless
torrent.ubuntu.com
ubuntu.com
etc

Yeah, that makes more sense.

@glassez
Copy link
Member

glassez commented Jan 31, 2025

When there are a lot of torrents with errors, it is impossible to find out if there are errors on a certain tracker without the help of third party tools. Here is a good example: other error 5206, 5205 torrents have a tracker temporarily down, to find out which tracker is down on 5206 I need to go through all of them manually.

Is separating the filter supposed to help you with this?

@xavier2k6
Copy link
Member

@stalkerok Do you mean that it may be better to have a more granular filter for each Tracker message for e.g. Banned by IP Filter / timed-out / torrent aborted / tracker sent a failure message / The I/O operation has been aborted because of either a thread exit or an application request as I believe "status" would only display working/not working/not contacted yet??

For e.g. I think having a Banned by IP Filter filter available in the "Filters Sidebar" would make it much easier to remove those trackers from all torrents etc.

@stalkerok
Copy link
Contributor Author

Is separating the filter supposed to help you with this?

Of course! There will be two filters instead of one: by tracker and by tracker status. This way I can filter out the last torrent with an error.

Do you mean that it may be better to have a more granular filter for each Tracker message for e.g. Banned by IP Filter / timed-out / torrent aborted / tracker sent a failure message / The I/O operation has been aborted because of either a thread exit or an application request as I believe "status" would only display working/not working/not contacted yet??

No, I'm only interested in tracker errors. As a rule, for me other errors, are temporary errors, as all unnecessary trackers are removed at the stage of adding a torrent (or later). The way I see it is this:
TRACKER STATUS
All (torrents with status working or stopped torrents/not contacted yet)
Tracker error
Other error
Warning

@glassez
Copy link
Member

glassez commented Jan 31, 2025

Is separating the filter supposed to help you with this?

Of course! There will be two filters instead of one: by tracker and by tracker status. This way I can filter out the last torrent with an error.

Could you describe entire scenario?

@stalkerok
Copy link
Contributor Author

Could you describe entire scenario?

I have two filters, one filter I put on other error, the second filter I put on each tracker in turn, that way I get a match and the torrent with that tracker and that error will be shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants