Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support alb-ingress-controller v2.x.x #11

Open
peimanja opened this issue Nov 22, 2020 · 3 comments
Open

[Feature Request] Support alb-ingress-controller v2.x.x #11

peimanja opened this issue Nov 22, 2020 · 3 comments

Comments

@peimanja
Copy link

alb-ingress-controller v2 has released.

@mogul
Copy link

mogul commented Jan 6, 2021

I've implemented this in #13

@headcr4sh
Copy link
Collaborator

Thanks for the work, @mogul!

Support for the new AWS Ingress Controller that I am looking forward to and it's definitely on my wishlist.

I think it doesn't make sense though, to create a new Github repository (terraform-kubernetes-aws-ingress-controller) to reflect the changes in the upstream software package. I will therefore not merge your pull request into this repository, because I feel that a new repository would be the better fit.

I am also not quite sure if Helm is the way to go here and I am right now thinking about using the new kubernetes-alpha provider plugin (which will eventually be merged back into the stable kubernetes provider plugin). I am not quite sure about the pros and cons at this point and will have to think a bit before making a quick decision.

@mercuriete
Copy link

@mogul
I am trying your repo and you forgot to add
alb_controller_depends_on = something

In the snippet example inside the README.md

so your PR doesn't work using the example which is bad.

BTW, I can't open issues on this repo: https://github.com/GSA/terraform-kubernetes-aws-load-balancer-controller
so, please open the possibility to report issues because I don't want to pollute this issue.

Thank you very much @mogul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants