Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In my opinion,the noise_amp should be the standard deviation,not the variance.& the normalization may be wrong #38

Open
yjyddq opened this issue Oct 10, 2022 · 0 comments

Comments

@yjyddq
Copy link

yjyddq commented Oct 10, 2022

The document in gnuradio.channels.dynamic_channel_model indicates that the -noise_amp – Specifies the standard deviation of the AWGN process .
So, I think there should be noise_amp = np.sqrt(10**(- snr/10)), original code is the variance.
aa4174a2ec70cd311c2d8677adbc07b
Besides, the Normalization of the energy may be the energy=np.sqrt(np.sum(np.abs(sample_vector)**2)),sample_vector = sample_vector / energy, rather than the following form, the former formula can promise after be normalized the total energy of a complex vector equals to one.
860ee0593afeaa52e2ca3ad7cbe43c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant