Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend SchedulerLoadDataEventArgs to include SelectedView #1898

Open
paulo-rico opened this issue Jan 8, 2025 · 1 comment
Open

Extend SchedulerLoadDataEventArgs to include SelectedView #1898

paulo-rico opened this issue Jan 8, 2025 · 1 comment

Comments

@paulo-rico
Copy link
Contributor

Hi Team

There are times when I would like to react to the change in the selected view, i.e. surrounding UI changes e.t.c.

I have extended SchedulerLoadDataEventArgs to include this and to ensure no breaking changes -

    public class SchedulerLoadDataEventArgs
    {
        /// <summary>
        /// The start of the currently rendered period.
        /// </summary>
        public DateTime Start { get; set; }
        /// <summary>
        /// The start of the currently rendered period.
        /// </summary>
        public DateTime End { get; set; }
        /// <summary>
        /// The selected view of the scheduler.
        /// </summary>
        public ISchedulerView View { get; set; }

    }

It does work as desired without breaking existing usage. My question is:
Is passing ISchedulerView back acceptable?

If so, I can fire a PR off straight away.

Regards

Paul

@akorchev
Copy link
Collaborator

akorchev commented Jan 8, 2025

Hi @paulo-rico,

Is passing ISchedulerView back acceptable?

I think so. Don't see any reason not to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants