Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report of SOLID #5

Open
iGioRojas opened this issue Nov 21, 2020 · 1 comment
Open

Report of SOLID #5

iGioRojas opened this issue Nov 21, 2020 · 1 comment

Comments

@iGioRojas
Copy link

Hi! This message is a suggestion for your code to be SOLID compliant.
Inheritance in the account class allows the checking account and savings account classes to handle their own transactions. Complying with Single Responsibility Principle.

The ATM and OptionMenu classes inherit from Account class, this element aren't relationship with inherit and maybe in the future the class will have unnecessary inheritance. Open-Close Principle.

@pratitid09
Copy link

hi , I am interested to take the issue of implement using Solid principles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants