Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show built-in extensions by default #13469

Merged
merged 5 commits into from
Feb 26, 2025
Merged

Don't show built-in extensions by default #13469

merged 5 commits into from
Feb 26, 2025

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Feb 21, 2025 •
edited
Loading

Summary

Fixes #13468
Fixed #8134

Occurred changes and/or fixed issues

Only shows built-in extensions on the new 'built-in' tab, which is now only shown when the user has enabled the extension developer preference.

Testing

Validate that when you go to 'Extensions' that no built-in extensions show up.

Go to preferences and enable the preference 'Enable Extension developer features'.

Go back to extensions and you should see a new Built-in tab:

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.11.0 milestone Feb 21, 2025
@nwmac nwmac requested a review from richard-cox February 21, 2025 15:27
richard-cox
richard-cox requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one probable tweak needed

@nwmac nwmac force-pushed the fix-builtin-extensions branch from cc1ae35 to e67396e Compare February 24, 2025 13:47
@nwmac nwmac requested a review from richard-cox February 24, 2025 14:48
@nwmac
Copy link
Member Author

nwmac commented Feb 25, 2025

@richard-cox Updated now and gates passed

@nwmac nwmac force-pushed the fix-builtin-extensions branch from 9c78c19 to f3553a3 Compare February 25, 2025 13:11
richard-cox
richard-cox requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, missed a couple of e2e comments on first review. outside of tests though all is good

@nwmac nwmac force-pushed the fix-builtin-extensions branch from f3553a3 to 746b5bd Compare February 26, 2025 16:08
@nwmac nwmac requested a review from richard-cox February 26, 2025 16:30
@nwmac nwmac merged commit 3665e77 into rancher:master Feb 26, 2025
31 checks passed
@nwmac nwmac deleted the fix-builtin-extensions branch February 26, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees

@nwmac nwmac

Labels
None yet
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.

Conditionally Show Built-In Extensions Extensions: Consider built-in extensions when choosing initial tab
2 participants
@nwmac @richard-cox