Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet GitRepo wizard UX improvements, new steps, fields size and banners #13437

Merged
merged 10 commits into from
Feb 27, 2025

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented Feb 17, 2025

Summary

Fixes #13402
Fixes #13473

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Metadata

image

Repository details

image

Target Details

image

Advanced

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@torchiaf torchiaf force-pushed the 13402-wizard-steps branch 6 times, most recently from eabf485 to 4217ab7 Compare February 24, 2025 17:03
@torchiaf torchiaf added this to the v2.11.0 milestone Feb 24, 2025
@torchiaf torchiaf changed the title 13402 wizard steps GitRepo wizard UX improvements, new steps, fields size and banners Feb 24, 2025
@torchiaf torchiaf marked this pull request as ready for review February 24, 2025 19:31
@torchiaf torchiaf force-pushed the 13402-wizard-steps branch 2 times, most recently from 6aa4d52 to 9d289ab Compare February 25, 2025 12:25
@torchiaf torchiaf changed the title GitRepo wizard UX improvements, new steps, fields size and banners Fleet GitRepo wizard UX improvements, new steps, fields size and banners Feb 25, 2025
Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see issues code-wise.

LGTM

Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
…o banner and fix labels

Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf
Copy link
Member Author

torchiaf commented Feb 26, 2025

@edenhernandez-suse and QA: I included only a few features from the original design:

  • Warning banner on top of the Advanced step
  • Steps positions and descriptions
  • Added icons to Add buttons

Steps centered layout, fields size and summary will be for 2.12, considering that Wizard is in common with Charts pages

@torchiaf torchiaf merged commit dc34dcc into rancher:master Feb 27, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants