Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning banner with wrong formatting in - Add Helm OCI Repository #13062

Open
IsaSih opened this issue Jan 10, 2025 · 2 comments · May be fixed by #13479
Open

Warning banner with wrong formatting in - Add Helm OCI Repository #13062

IsaSih opened this issue Jan 10, 2025 · 2 comments · May be fixed by #13479
Assignees
@momesgin
Labels
area/apps kind/bug QA/manual-test Indicates issue requires manually testing
Milestone
v2.11.0

Comments

@IsaSih
Copy link
Contributor

IsaSih commented Jan 10, 2025

Setup

  • Rancher version: v2.11-e9f0646414809cbaee8a1de474d8da152b522f06-head
    Dashboard: master 938b866
    Rancher CLI: v2.11.0-rc.1

Describe the bug

Warning banner is displayed with wrong formatting in - Add Helm OCI Repository

To Reproduce
1- From the side menu bar in rancher dashboard UI, select the local cluster
2- Go to Apps > Repositories > Create
3- Select OCI Repository

Result
Observe that the warning banner is displayed with the wrong formatting

Expected Result
Warning banner must be displayed with the warning banner style

Screenshots
Screenshot 2025-01-10 at 12 27 17
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jan 10, 2025
@IsaSih IsaSih added this to the v2.11.0 milestone Jan 10, 2025
@IsaSih IsaSih mentioned this issue Jan 10, 2025
Closed
@nwmac
Copy link
Member

nwmac commented Feb 17, 2025

@momesgin Maybe you could pick this up - the banner should be info

@momesgin momesgin self-assigned this Feb 18, 2025
@momesgin momesgin added area/apps QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Feb 18, 2025
@momesgin
Copy link
Member

@kwwii reviewed this and here's what needs to be changed:

  1. "Add OCI URLs that contain ONLY helm charts." should be changed to "OCI URLs should ONLY contain helm charts.", and displayed as a warning banner
  2. The last part of the message should be removed "The list of charts available from the repository is updated every 6 hours."
  3. The rest of the message should be displayed as an info banner

@momesgin momesgin linked a pull request Feb 21, 2025 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@momesgin momesgin

Labels
area/apps kind/bug QA/manual-test Indicates issue requires manually testing
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging a pull request may close this issue.

Update OCI repo creation message momesgin/dashboard
3 participants
@nwmac @IsaSih @momesgin