Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown Menu: Arrow keys do not select items after triggering the menu with the mouse #13484

Closed
2 tasks
rak-phillip opened this issue Feb 21, 2025 · 1 comment · Fixed by #13485
Closed
2 tasks

Comments

@rak-phillip
Copy link
Member

rak-phillip commented Feb 21, 2025

Dropdown menu items are not able to be focused via keyboard after opening a dropdown menu with the mouse.

Steps to reproduce

  1. Open a dropdown menu with the mouse (page header actions, user menu)
  2. press the down key

Expected behavior

The first dropdown item will receive focus

Actual behavior

No dropdown items receive focus

Acceptance criteria

  • Pressing the down key after opening a dropdown with the mouse focuses the first item
  • Subsequent up/down keypresses focus the appropriate item

Details

It looks like handleKeydown inadvertently got deleted. This causes a regression where arrow keys can no longer handle selection after opening a dropdown with the mouse. I suspect this got deleted due to a bad resolution for a merge conflict.

Originally posted by @rak-phillip in #13357 (comment)

@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Feb 21, 2025
@rak-phillip rak-phillip changed the title It looks like handleKeydown inadvertently got deleted. This causes a regression where arrow keys can no longer handle selection after opening a dropdown with the mouse. I suspect this got deleted due to a bad resolution for a merge conflict. Dropdown Menu: Arrow keys do not select items after triggering the menu with the mouse Feb 21, 2025
@rak-phillip rak-phillip self-assigned this Feb 21, 2025
@rak-phillip rak-phillip added this to the v2.11.0 milestone Feb 21, 2025
@a-arias
Copy link
Contributor

a-arias commented Feb 26, 2025

Existing tests are located in: #13357,

the coverage looks good moving to done ✅

@a-arias a-arias removed the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Feb 26, 2025
@a-arias a-arias closed this as completed Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants