Replace extension menu with ActionMenuShell.vue
#13505
Conversation
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
There was a problem hiding this comment.
It seems to work as intended @rak-phillip but there's a couple of things popping up on the console:
When I open it I get
And if I click Manage Repositories the console get quite a few warnings like
This is what I'm attempting to call out in the technical notes section of the PR description
The action menu is designed in such a way that events are emitted dynamically; this makes it difficult to satisfy the constraint of explicitly defining emits without requiring a larger refactor in how the action menu behaves.. I'm open to suggestions and ideas at this point.
hmmm.. I see this now, I'll have to investigate to better understand the root cause |
Signed-off-by: Phillip Rak <[email protected]>
Summary
This replaces the extensions menu with the ActionMenuShell component. Using the new action menu component provides us with out of the box accessibility features and keyboard navigation.
Fixes #13504
Occurred changes and/or fixed issues
Technical notes summary
The design of the existing action menu operates in such a way that emitted events are not declared. I attempted to find a way to work around the Vue warnings we receive when emitting events in this way, but we might need to refactor how custom actions are emitted. I'm open to suggestions on how to resolve this without requiring a larger refactor.
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist