Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot remove annotations on imported or local k3s and rke2 clusters #13470

Open
rancher-max opened this issue Feb 21, 2025 · 0 comments · May be fixed by #13524
Open

Cannot remove annotations on imported or local k3s and rke2 clusters #13470

rancher-max opened this issue Feb 21, 2025 · 0 comments · May be fixed by #13524
Assignees
Labels
kind/bug kind/bug-qa QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this status/release-blocker
Milestone

Comments

@rancher-max
Copy link
Member

rancher-max commented Feb 21, 2025

Setup

  • Rancher version: head (2.11)
  • Rancher UI Extensions:
  • Browser type & version: Firefox 135.0.1
Image

Describe the bug

Cannot remove annotations after adding them on imported k3s and rke2 clusters.

Found when testing #9476

To Reproduce

Can be reproduced with either local cluster or an imported cluster. Steps for local cluster:

  1. Setup rancher on k3s or rke2
  2. Edit local cluster config
  3. Add an annotation with a key and value
  4. Try to remove the annotation using the "Remove" button on the right, either before or after saving

Result
Cannot remove the annotation.

Note that there is a workaround by removing the text inside of the annotation, then clicking the remove button.

Expected Result

Annotation should be removed without having to clear the text first.

Screenshots

Screen.Recording.2025-02-21.at.8.54.30.AM.mov

Additional context

If there are multiple "empty" annotations, then clicking one remove button will remove all of them. This is a separate issue, and I do not view that bit as a bug personally. I am calling it out here because it can feel a bit weird and lead to a degraded UX -- for example, if I know I want to add 5 annotations, then accidentally click the button 6 times, then try to remove one empty field, it will remove all of them and I'll have to click the button 5 times on my second attempt.

Note that in frustration, when I clicked 4 or 5 times in quick succession on the Remove button, I was able to remove an annotation.

@rancher-max rancher-max added this to the v2.11.0 milestone Feb 21, 2025
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Feb 21, 2025
@momesgin momesgin self-assigned this Feb 25, 2025
@momesgin momesgin linked a pull request Feb 27, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug kind/bug-qa QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this status/release-blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants