Update pagination settings (almost) ready for production #13159
Conversation
|
TBD. With all the resource.changes issues it feels like having the Performance setting OFF but the vai cache ON is not a viable configuration. The perf setting enabled/disabled should just be removed and everything should just be gated on vai cache and perf setting resource list. Previously the perf enabled/disabled flags controlled disabling the incompatible features as well, so need to ensure they are ignored if vai cache on (and inform user in perf page). Update: The above is true, but a lot of work (where settings are read they need to override given others), so the pagination setting and feature flag will remain separate atm |
richard-cox
force-pushed
the
pagination-settings-update
branch
from
d42522c to
387a4bb
Compare
richard-cox
force-pushed
the
pagination-settings-update
branch
2 times, most recently
from
1d50efa to
7f7feb4
Compare
shell/assets/translations/en-us.yaml
Outdated
| applicable: "This applies to the following resource types" | ||
| checkboxUseDefault: | ||
| label: Enable Custom Resources | ||
| placeholder: Customize the resources that server-side pagination applies to. This is an advanced feature and must be managed outside of the UI. Customized resource types are not updated on Rancher upgrade and must be manually changed. |
There was a problem hiding this comment.
I would think we'd like to link to some docs so the user can do this if they so choose.
There was a problem hiding this comment.
Good comment!
We're on a big push for a cleaner UI and stuff like this is pretty advanced, we wouldn't expect users to exercise it without direct instruction / instructions from us anyway. With all that in mind just nuked it.
| @@ -189,11 +199,15 @@ export default { | |||
| }); | |||
| }, | |||
| setPaginationDefaults() { | |||
| sspApplyDefaults(defaultStore) { | |||
There was a problem hiding this comment.
I understand what you're doing here but from a user perspective I find how we apply defaults jarring.
jarring.mp4
I expected to set the resources to the default not all the settings. I wanted to look at the resources to see if anything changed but everything got disabled and closed.
There was a problem hiding this comment.
This was just a convenience thing for development (gated on isDev), removed
- 'almost' applies to enabling SSP by default - Previously the ui-performance object contained a required set of resources to apply SSP to - This isn't workable going forward where the available resources will be updated between versions - Now the default is to use a set of default resources which can change between versions - Users can override if they wish
error in ../../shell/plugins/steve/steve-pagination-utils.ts:37:50
TS2339: Property 'name' does not exist on type 'Namespace'.
35 | if (hideObscure || hideSystem) {
36 | res.push(PaginationParamFilter.createSingleField({
> 37 | field: 'metadata.namespace', value: ns.name, equals: false
| ^^^^
38 | }));
39 | }
richard-cox
force-pushed
the
pagination-settings-update
branch
from
5254ce5 to
dcea7c6
Compare
…e reliability - there's some flakeyness in the test - running it locally though crashes cypress browser session - split into three to improve tests, which now pass locally
- bring back 'liable to change' notice and add 'not in prod' - move location down below long term settings
|
@codyrancher ok, think changes are done now. i've got e2e tests passing and also brought back the warning message given SSP is not on by default |
Summary
Fixes #13089
Occurred changes and/or fixed issues
Areas or cases that should be tested
/v3/settings/ui-performancevalue set to an empty string). No pagination anywheredefaultsbutton and enable SSP to populate theresources with default. Pagination on for places like the home page. Tweak the resources (storeobject) like changing thecontextof the prov cluster to not includehome(likehomeaaa`). Pagination on home page should not be onChecklist