Fix Header keyboard navigation #13369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalves08
force-pushed
the
header-key-nav-2
branch
from
1ff2c9a to
b53a2f6
Compare
This was
linked to
issues
Feb 12, 2025
aalves08
force-pushed
the
header-key-nav-2
branch
from
b53a2f6 to
2bd801d
Compare
rak-phillip
reviewed
Feb 13, 2025
shell/components/AppModal.vue
Outdated
| @@ -107,7 +111,10 @@ export default defineComponent({ | |||
| width: this.modalWidth, | |||
| ...this.stylesPropToObj, | |||
| }; | |||
| } | |||
| }, | |||
| isCodeMirrorFocused() { | |||
There was a problem hiding this comment.
I think that we will be able to remove the need for AppModal to know about the code mirror if we solve the issue with event listeners on the document.
There was a problem hiding this comment.
Since the onReady event was already being bubbled up with the correct reference of the code mirror instance, I've updated Import to pass it to Header then we can use it in AppModal. With that we could remove all selectors and weird logic. Check this commit with all the changes
aalves08
force-pushed
the
header-key-nav-2
branch
from
2bd801d to
cb8266f
Compare
aalves08
force-pushed
the
header-key-nav-2
branch
from
f1fe42a to
4234ccb
Compare
rak-phillip
reviewed
Feb 19, 2025
|
@rak-phillip PR updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12778 #8113
Occurred changes and/or fixed issues
HeadercomponentImport YAMLmodal (updatedCodeMirrorcomponent to handle blur withescapekey)Kubectl Shellarea (updatedContainerShellcomponent to handle blur withescapekey)Describe Resourcearea (slide in panel with resource description/explanation)Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Screen.Recording.2025-02-11.at.12.20.33.mov
Checklist