Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic OIDC group scope is not sent in the request formed by the UI #13421

Closed

Conversation

cnotv
Copy link
Member

@cnotv cnotv commented Feb 14, 2025

Summary

Fixes #12477

Occurred changes and/or fixed issues

Included scopes in the Keycloack pop-up as indicated in the issue.

Technical notes summary

It seems like scope was not added to the whole logic after passing the list from the UI.

In the store logic it's also mispelled to plural as scopes.
The function where it gets added has not been changed since 5 years and is not working.

dashboard/store/auth.js

Lines 141 to 143 in f76baeb

if ( opt.scopes ) {
addObjects(scopes, opt.scopes);
}

  • Replaced addObjects() with new joinStringList()
  • Added tests to the redirectTo action to generate redirect URL to auth provider pop up with all the involved cases
  • Added tests to the test action to pass all the required options to compose the redirect URL
  • Added tests to the auth-config mixin used in the view to submit the auth configuration
  • Added tests to the utility function concatStrings()

Areas or cases that should be tested

As by reported issue.

Areas which could experience regressions

  • Auth with other non-SAML providers (Azure has E2E)

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@cnotv cnotv closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic OIDC group scope is not sent in the request formed by the UI
1 participant