Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "User Login Filter" input to the LDAP auth provider config #13464

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Feb 20, 2025

Summary

This adds the "User Login Filter" input to the LDAP config form.

Fixes #13419

Occurred changes and/or fixed issues

  • Add "User Login Filter" input to the LDAP config form
  • Re-flow form contents (requires manually shifting each input by one)

Technical notes summary

Because this change include moving form elements around, I recommend reviewing each commit one at a time.

Areas or cases that should be tested

  • Active Directory
  • OpenLDAP
  • FreeIPA

Areas which could experience regressions

  • NA

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.11.0 milestone Feb 20, 2025
@rak-phillip rak-phillip force-pushed the task/13419-user-login-filter branch from ccf5f63 to 87d6173 Compare February 26, 2025 18:45
@rak-phillip rak-phillip marked this pull request as ready for review February 26, 2025 18:46
@rak-phillip rak-phillip changed the title Task/13419 user login filter Add "User Login Filter" input to the LDAP auth provider config Feb 26, 2025
@rak-phillip rak-phillip force-pushed the task/13419-user-login-filter branch from 87d6173 to 355a90b Compare February 26, 2025 18:57
@rak-phillip rak-phillip force-pushed the task/13419-user-login-filter branch from 355a90b to 1fa73c0 Compare February 26, 2025 18:58
@rak-phillip rak-phillip requested review from codyrancher and removed request for jordojordo February 26, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add "User Login FIlter" text box to the auth provider config pages
2 participants