Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OCI repo creation message #13479

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

momesgin
Copy link
Member

Summary

Fixes #13062

Occurred changes and/or fixed issues

  • "Add OCI URLs that contain ONLY helm charts." changed to "OCI URLs should ONLY contain helm charts.", and displayed as a warning banner
  • The last part of the message is removed "The list of charts available from the repository is updated every 6 hours."
  • The rest of the message is displayed as an info banner

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@momesgin momesgin added this to the v2.11.0 milestone Feb 21, 2025
@momesgin momesgin self-assigned this Feb 21, 2025
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighting OCI URLs should ONLY contain helm charts. underlines that it's confusing. Should the url itself contain a reference to a specific helm chart collection, or should the url location only contain helm charts? Should this be

OCI repositories should ONLY contain helm charts.

@rohitsakala can you advise?

@rohitsakala
Copy link
Member

rohitsakala commented Feb 24, 2025

@richard-cox Right now, if the OCI registry instead of an OCI repository is provided like oci://{host}:5000 and this registry only contains helm charts then it is supported . If the user provides OCI repository URL like oci://{host}:5000/helmcharts or oci://{host}:5000/rancher/helmcharts and only contain helmcharts, then it is supported. Let me know if this clarifies your question.

@richard-cox
Copy link
Member

Thanks @rohitsakala , that makes sense.

@momesgin Maybe we should go with something like ...

OCI URLs must ONLY target helm chart/s

@momesgin
Copy link
Member Author

Thanks @rohitsakala , that makes sense.

@momesgin Maybe we should go with something like ...

OCI URLs must ONLY target helm chart/s

Sounds good

@momesgin momesgin requested a review from richard-cox February 26, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning banner with wrong formatting in - Add Helm OCI Repository
3 participants