Replace locale selector on login page with RcDropdown component #13487
+67
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires #13485 to fix the keyboard focus behavior when opening the menu with a mouse. |
richard-cox
reviewed
Feb 24, 2025
| :flip="false" | ||
| :container="false" | ||
| @focus.capture="openLocaleSelector" | ||
| <rc-dropdown v-if="showLocale"> |
There was a problem hiding this comment.
Shouldn't this be using the new action drop down?
There was a problem hiding this comment.
My reasons for taking this approach are in the description. I chose the component-driven approach because the existing implementation of the locale selector more closely matches this pattern and requires less refactoring.
There was a problem hiding this comment.
We could potentially replace the implementation in this PR with the new action menu after #13505 merges.
rak-phillip
force-pushed
the
task/language-dropdown
branch
2 times, most recently
from
e428779 to
414f1e2
Compare
Signed-off-by: Phillip Rak <[email protected]>
Because the locale selector is located at the bottom of the login page, it feels more natural to use the `up` key to select an item after opening the menu with the mouse. The default behavior when opening the menu with the keyboard will remain unchanged. Signed-off-by: Phillip Rak <[email protected]>
rak-phillip
force-pushed
the
task/language-dropdown
branch
from
414f1e2 to
414c5d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces the locale selector on the login page with the RcDropdown component.
Fixes #13486
Occurred changes and/or fixed issues
Technical notes summary
This is a fairly straightforward transfer of the custom dropdown menu to RcDropdown. I opted to use RcDropdown instead of the props-driven RcDropdownMenu component because the existing implementation requires less refactoring for the component-driven approach.
Areas or cases that should be tested
Areas which could experience regressions
Pay attention to any accessibility enhancements that might have been previously made in recent PRs. We do not want to regress in these areas.
Screenshot/Video
Checklist